Enable tests for #202 on macOS with Xcode 12+, add catalina workflow #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
changed the title
chapulina
approved these changes
Nov 7, 2020
| @@ -0,0 +1,45 @@ | |||
| name: macOS latest | |||
There was a problem hiding this comment.
Sweet, we should use this template for the other libraries too! gazebo-tooling/action-gz-ci#25
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Nov 8, 2020
…workflow (gazebosim#414) Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Nov 8, 2020
…workflow (gazebosim#414) Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Nov 10, 2020
…414) Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 14, 2020
…workflow (gazebosim#414) Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 15, 2020
…atalina workflow (gazebosim#414)" This reverts commit 0e77816.
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 15, 2020
…workflow (gazebosim#414) Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Dec 15, 2020
…414) Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the clang bug causing #202 has been fixed in Xcode 12+, which is available on macOS 10.15 Catalina. This re-enables those disabled tests for Xcode 12+ and adds a GitHub workflow for macOS Catalina to confirm the fix.